Skip to content

feat(migrate-legacy-buffer-atob-btoa): introduce #206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

feat(migrate-legacy-buffer-atob-btoa): introduce #206

wants to merge 9 commits into from
+257 −0

Conversation

nekojanai
Copy link
Contributor

@nekojanai nekojanai commented Sep 10, 2025 •
edited
Loading

closes #98

brunocroh
brunocroh reviewed Sep 10, 2025
View reviewed changes
AugustinMauroy
AugustinMauroy reviewed Sep 10, 2025
View reviewed changes
Copy link
Member

@AugustinMauroy AugustinMauroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noice! But my advice is to start writing test commit them on local then build the codemod and then push everything

@nekojanai nekojanai force-pushed the feat(`migrate-legacy-buffer-atob-btoa`) branch from 23a2fcf to 2c2fee2 Compare September 17, 2025 16:34
@nekojanai nekojanai force-pushed the feat(`migrate-legacy-buffer-atob-btoa`) branch from 2c2fee2 to f6f823e Compare September 17, 2025 16:37
@nekojanai nekojanai marked this pull request as ready for review September 17, 2025 16:38
@nekojanai nekojanai requested a review from brunocroh September 17, 2025 16:40
AugustinMauroy
AugustinMauroy reviewed Sep 17, 2025
View reviewed changes
Copy link
Member

@AugustinMauroy AugustinMauroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing test/feature:

  • dynamic import
  • esm import

@nekojanai
Copy link
Contributor Author

@AugustinMauroy Could you provide examples for dynamic and esm imports to test against?

@AugustinMauroy
Copy link
Member

ESM import

Input/before:

import buffer from "node:buffer";

// do stuff

Dynamic import

const buffer = await import("node:buffer");

// do stuff

Don't worry it's shouldn't complicated because we have serval utilities for that

@JakobJingleheimer JakobJingleheimer added the awaiting author Reviewer has requested something from the author label Sep 24, 2025
brunocroh
brunocroh reviewed Sep 28, 2025
View reviewed changes
@nekojanai nekojanai requested a review from brunocroh September 30, 2025 19:37
@nekojanai
Copy link
Contributor Author

Should be gtm

@brunocroh brunocroh removed the awaiting author Reviewer has requested something from the author label Sep 30, 2025
brunocroh
brunocroh approved these changes Sep 30, 2025
View reviewed changes
Copy link
Member

@brunocroh brunocroh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great now, Thank you!

AugustinMauroy
AugustinMauroy reviewed Oct 1, 2025
View reviewed changes
AugustinMauroy
AugustinMauroy reviewed Oct 1, 2025
View reviewed changes
AugustinMauroy
AugustinMauroy reviewed Oct 1, 2025
View reviewed changes
AugustinMauroy
AugustinMauroy reviewed Oct 1, 2025
View reviewed changes
@AugustinMauroy AugustinMauroy added the awaiting author Reviewer has requested something from the author label Oct 1, 2025
avivkeller
avivkeller reviewed Oct 10, 2025
View reviewed changes
@nekojanai
Copy link
Contributor Author

@AugustinMauroy should be gtm now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brunocroh brunocroh brunocroh approved these changes

@avivkeller avivkeller avivkeller approved these changes

@AugustinMauroy AugustinMauroy Awaiting requested review from AugustinMauroy

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

awaiting author Reviewer has requested something from the author

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

feat: Migrate legacy buffer.atob(data) and buffer.btoa(data) APIs

5 participants

@nekojanai @AugustinMauroy @brunocroh @avivkeller @JakobJingleheimer